Change in openvpn[master]: configure: Remove --enable-strict
A message that is not in the archive (sent off-list or not yet received): gerrit.1774451380000.I53e7b984980cb1e2b3f68e80358b61c9e1045725@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1590?usp=email
to review the following change.
Change subject: configure: Remove --enable-strict
......................................................................
configure: Remove --enable-strict
Both -Wsign-compare (via -Wextra) and -Wuninitalized (via -Wall) are enabled by default. So this does not do anything anymore.
While here also remove rest of --enable-strict-options which was mostly removed in commit 2104ea62430e4d203f2cd998e053f4192798b9f1
---
M CMakeLists.txt
M configure.ac
2 files changed, 1 insertion(+), 19 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/1590/1
CMakeLists.txt +1 -1
@@ -112,7 +112,7 @@ add_link_options("$<$<CONFIG:Release>:/CETCOMPAT>") endif() else () - add_compile_options(-Wall -Wuninitialized) + add_compile_options(-Wall) check_and_add_compiler_flag(-Wno-stringop-truncation NoStringOpTruncation) check_and_add_compiler_flag(-Wstrict-prototypes StrictPrototypes) check_and_add_compiler_flag(-Wold-style-definition OldStyleDefinition)
configure.ac +0 -18
@@ -203,13 +203,6 @@ ) AC_ARG_ENABLE( - [strict], - [AS_HELP_STRING([--enable-strict], [enable strict compiler warnings (debugging option) @<:@default=no@:>@])], - , - [enable_strict="no"] -) - -AC_ARG_ENABLE( [pedantic], [AS_HELP_STRING([--enable-pedantic], [enable pedantic compiler warnings, will not generate a working executable (debugging option) @<:@default=no@:>@])], ,
@@ -224,13 +217,6 @@ ) AC_ARG_ENABLE( - [strict-options], - [AS_HELP_STRING([--enable-strict-options], [enable strict options check between peers (debugging option) @<:@default=no@:>@])], - , - [enable_strict_options="no"] -) - -AC_ARG_ENABLE( [selinux], [AS_HELP_STRING([--enable-selinux], [enable SELinux support @<:@default=no@:>@])], ,
@@ -1270,13 +1256,9 @@ fi if test "${enable_pedantic}" = "yes"; then - enable_strict="yes" CFLAGS="${CFLAGS} -pedantic" AC_DEFINE([PEDANTIC], [1], [Enable pedantic mode]) fi -if test "${enable_strict}" = "yes"; then - CFLAGS="${CFLAGS} -Wsign-compare -Wuninitialized" -fi if test "${enable_werror}" = "yes"; then CFLAGS="${CFLAGS} -Werror" fi
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1590?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725
Gerrit-Change-Number: 1590
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1590?usp=email )
Change subject: configure: Remove --enable-strict
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1590?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725
Gerrit-Change-Number: 1590
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Mon, 27 Apr 2026 17:47:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
PATCH 1/1 configure: Remove --enable-strict
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
Both -Wsign-compare (via -Wextra) and -Wuninitalized (via -Wall) are enabled by default. So this does not do anything anymore.
While here also remove rest of --enable-strict-options which was mostly removed in commit 2104ea62430e4d203f2cd998e053f4192798b9f1
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1590
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1590
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>
CMakeLists.txt +1 -1
@@ -112,7 +112,7 @@ add_link_options("$<$<CONFIG:Release>:/CETCOMPAT>") endif() else () - add_compile_options(-Wall -Wuninitialized) + add_compile_options(-Wall) check_and_add_compiler_flag(-Wno-stringop-truncation NoStringOpTruncation) check_and_add_compiler_flag(-Wstrict-prototypes StrictPrototypes) check_and_add_compiler_flag(-Wold-style-definition OldStyleDefinition)
configure.ac +0 -18
@@ -203,13 +203,6 @@ ) AC_ARG_ENABLE( - [strict], - [AS_HELP_STRING([--enable-strict], [enable strict compiler warnings (debugging option) @<:@default=no@:>@])], - , - [enable_strict="no"] -) - -AC_ARG_ENABLE( [pedantic], [AS_HELP_STRING([--enable-pedantic], [enable pedantic compiler warnings, will not generate a working executable (debugging option) @<:@default=no@:>@])], ,
@@ -224,13 +217,6 @@ ) AC_ARG_ENABLE( - [strict-options], - [AS_HELP_STRING([--enable-strict-options], [enable strict options check between peers (debugging option) @<:@default=no@:>@])], - , - [enable_strict_options="no"] -) - -AC_ARG_ENABLE( [selinux], [AS_HELP_STRING([--enable-selinux], [enable SELinux support @<:@default=no@:>@])], ,
@@ -1270,13 +1256,9 @@ fi if test "${enable_pedantic}" = "yes"; then - enable_strict="yes" CFLAGS="${CFLAGS} -pedantic" AC_DEFINE([PEDANTIC], [1], [Enable pedantic mode]) fi -if test "${enable_strict}" = "yes"; then - CFLAGS="${CFLAGS} -Wsign-compare -Wuninitialized" -fi if test "${enable_werror}" = "yes"; then CFLAGS="${CFLAGS} -Werror" fi
[Openvpn-devel] [PATCH applied] Re: configure: Remove --enable-strict
"Because it makes sense". Only affects configure -> Makefile flag setting.
Your patch has been applied to the master and release/2.7 branch (keep build environments aligned if possible).
commit ac62337dd5338ab5fe066f33a09f258dd04d0585 (master) commit 352d234bee0d88e8a03d84fc3d9c1cd773c19c43 (release/2.7)
Author: Frank Lichtenheld Date: Mon Apr 27 19:47:50 2026 +0200
configure: Remove --enable-strict
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1590
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36752.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1590?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: configure: Remove --enable-strict
......................................................................
configure: Remove --enable-strict
Both -Wsign-compare (via -Wextra) and -Wuninitalized (via -Wall) are enabled by default. So this does not do anything anymore.
While here also remove rest of --enable-strict-options which was mostly removed in commit 2104ea62430e4d203f2cd998e053f4192798b9f1
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1590
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36752.html
---
M CMakeLists.txt
M configure.ac
2 files changed, 1 insertion(+), 19 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/1590/2
CMakeLists.txt +1 -1
@@ -112,7 +112,7 @@ add_link_options("$<$<CONFIG:Release>:/CETCOMPAT>") endif() else () - add_compile_options(-Wall -Wuninitialized) + add_compile_options(-Wall) check_and_add_compiler_flag(-Wno-stringop-truncation NoStringOpTruncation) check_and_add_compiler_flag(-Wstrict-prototypes StrictPrototypes) check_and_add_compiler_flag(-Wold-style-definition OldStyleDefinition)
configure.ac +0 -18
@@ -203,13 +203,6 @@ ) AC_ARG_ENABLE( - [strict], - [AS_HELP_STRING([--enable-strict], [enable strict compiler warnings (debugging option) @<:@default=no@:>@])], - , - [enable_strict="no"] -) - -AC_ARG_ENABLE( [pedantic], [AS_HELP_STRING([--enable-pedantic], [enable pedantic compiler warnings, will not generate a working executable (debugging option) @<:@default=no@:>@])], ,
@@ -224,13 +217,6 @@ ) AC_ARG_ENABLE( - [strict-options], - [AS_HELP_STRING([--enable-strict-options], [enable strict options check between peers (debugging option) @<:@default=no@:>@])], - , - [enable_strict_options="no"] -) - -AC_ARG_ENABLE( [selinux], [AS_HELP_STRING([--enable-selinux], [enable SELinux support @<:@default=no@:>@])], ,
@@ -1270,13 +1256,9 @@ fi if test "${enable_pedantic}" = "yes"; then - enable_strict="yes" CFLAGS="${CFLAGS} -pedantic" AC_DEFINE([PEDANTIC], [1], [Enable pedantic mode]) fi -if test "${enable_strict}" = "yes"; then - CFLAGS="${CFLAGS} -Wsign-compare -Wuninitialized" -fi if test "${enable_werror}" = "yes"; then CFLAGS="${CFLAGS} -Werror" fi
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1590?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725
Gerrit-Change-Number: 1590
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1590?usp=email )
Change subject: configure: Remove --enable-strict
......................................................................
configure: Remove --enable-strict
Both -Wsign-compare (via -Wextra) and -Wuninitalized (via -Wall) are enabled by default. So this does not do anything anymore.
While here also remove rest of --enable-strict-options which was mostly removed in commit 2104ea62430e4d203f2cd998e053f4192798b9f1
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1590
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36752.html
---
M CMakeLists.txt
M configure.ac
2 files changed, 1 insertion(+), 19 deletions(-)
CMakeLists.txt +1 -1
@@ -112,7 +112,7 @@ add_link_options("$<$<CONFIG:Release>:/CETCOMPAT>") endif() else () - add_compile_options(-Wall -Wuninitialized) + add_compile_options(-Wall) check_and_add_compiler_flag(-Wno-stringop-truncation NoStringOpTruncation) check_and_add_compiler_flag(-Wstrict-prototypes StrictPrototypes) check_and_add_compiler_flag(-Wold-style-definition OldStyleDefinition)
configure.ac +0 -18
@@ -203,13 +203,6 @@ ) AC_ARG_ENABLE( - [strict], - [AS_HELP_STRING([--enable-strict], [enable strict compiler warnings (debugging option) @<:@default=no@:>@])], - , - [enable_strict="no"] -) - -AC_ARG_ENABLE( [pedantic], [AS_HELP_STRING([--enable-pedantic], [enable pedantic compiler warnings, will not generate a working executable (debugging option) @<:@default=no@:>@])], ,
@@ -224,13 +217,6 @@ ) AC_ARG_ENABLE( - [strict-options], - [AS_HELP_STRING([--enable-strict-options], [enable strict options check between peers (debugging option) @<:@default=no@:>@])], - , - [enable_strict_options="no"] -) - -AC_ARG_ENABLE( [selinux], [AS_HELP_STRING([--enable-selinux], [enable SELinux support @<:@default=no@:>@])], ,
@@ -1270,13 +1256,9 @@ fi if test "${enable_pedantic}" = "yes"; then - enable_strict="yes" CFLAGS="${CFLAGS} -pedantic" AC_DEFINE([PEDANTIC], [1], [Enable pedantic mode]) fi -if test "${enable_strict}" = "yes"; then - CFLAGS="${CFLAGS} -Wsign-compare -Wuninitialized" -fi if test "${enable_werror}" = "yes"; then CFLAGS="${CFLAGS} -Werror" fi
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1590?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725
Gerrit-Change-Number: 1590
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>